Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[http] fixing content-length checking #437

Merged
merged 2 commits into from
May 23, 2019
Merged

[http] fixing content-length checking #437

merged 2 commits into from
May 23, 2019

Conversation

zekth
Copy link
Contributor

@zekth zekth commented May 23, 2019

As mentionned in : #419
Fixing readRequest for the content length chekcking.

Note: https://github.com/denoland/deno_std/compare/master...zekth:fix_readRq?expand=1#diff-58b0092e6441ae4b79fb3069e2ba21ddR359

This one is still not working because of the trimming of the kv in textproto:
https://github.com/denoland/deno_std/blob/master/textproto/mod.ts#L114

I think it can stay like this for the moment

@ry
Copy link
Member

ry commented May 23, 2019

How is this done in Go?

@zekth
Copy link
Contributor Author

zekth commented May 23, 2019

How is this done in Go?

It's kind of the same way but our API is not really tied to the golang in some parts. It's inspired of: https://github.com/golang/go/blob/master/src/net/http/transfer.go#L670

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit ce4e3cc into denoland:master May 23, 2019
@zekth zekth deleted the fix_readRq branch May 23, 2019 16:02
ry pushed a commit to ry/deno that referenced this pull request Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants