Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(http): format test names #4400

Merged
merged 5 commits into from
Feb 27, 2024

Conversation

timreichen
Copy link
Contributor

Ref: #3754

@timreichen timreichen requested a review from kt3k as a code owner February 26, 2024 13:58
@github-actions github-actions bot added the http label Feb 26, 2024
@@ -127,7 +127,7 @@ class MockListener implements Deno.Listener {
}

Deno.test(
"Server.addrs should expose the addresses the server is listening on",
"Server() exposes the addresses the server is listening on as addrs property",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove the round brackets on class names?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks again, Tim.

@iuioiua iuioiua changed the title refactor(http): format test names chore(http): format test names Feb 27, 2024
@iuioiua iuioiua merged commit 8fbd39d into denoland:main Feb 27, 2024
12 checks passed
@timreichen timreichen deleted the http_format_test_names branch February 27, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants