-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use hyphens for JSR package exports #4424
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Maybe this needs more discussion, but I like the idea. @std/data-structures/binary_heap
looks ugly and looks hard to type
will this create any instability ? |
We did make a similar change in #4357. We can help by making migration instructions and release notes super-clear. |
This doesn't affect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Uses a consistent separator instead of mixing the two:
@std/data-structures/binary_heap
->@std/data-structures/binary-heap