Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(uuid): prepare for noUncheckedIndexedAccess #4445

Merged
merged 4 commits into from
Mar 10, 2024
Merged

refactor(uuid): prepare for noUncheckedIndexedAccess #4445

merged 4 commits into from
Mar 10, 2024

Conversation

syhol
Copy link
Contributor

@syhol syhol commented Mar 6, 2024

Handling all noUncheckedIndexedAccess issues for the uuid module, tracked in #4040

@syhol syhol requested a review from kt3k as a code owner March 6, 2024 11:03
@github-actions github-actions bot added the uuid label Mar 6, 2024
syhol
syhol commented Mar 6, 2024
View reviewed changes
uuid/mod.ts Show resolved Hide resolved
syhol
syhol commented Mar 6, 2024
View reviewed changes
uuid/v3.ts Show resolved Hide resolved
syhol
syhol commented Mar 6, 2024
View reviewed changes
uuid/v5.ts Show resolved Hide resolved
syhol
syhol commented Mar 6, 2024
View reviewed changes
uuid/v1.ts Show resolved Hide resolved
syhol
syhol commented Mar 6, 2024
View reviewed changes
uuid/v1.ts Outdated Show resolved Hide resolved
syhol
syhol commented Mar 6, 2024
View reviewed changes
uuid/v1.ts Outdated Show resolved Hide resolved
syhol
syhol commented Mar 6, 2024
View reviewed changes
uuid/v1.ts Outdated Show resolved Hide resolved
@syhol syhol force-pushed the uuid-no-unchecked-indexed-access branch from 0f39483 to 3651a3c Compare March 6, 2024 11:43
iuioiua
iuioiua suggested changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple more nits. Can you please tweak the test with the suggested output?

uuid/v1.ts Outdated Show resolved Hide resolved
iuioiua
iuioiua approved these changes Mar 10, 2024
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

@iuioiua iuioiua merged commit 5c23dcb into denoland:main Mar 10, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuioiua iuioiua iuioiua approved these changes

@kt3k kt3k Awaiting requested review from kt3k kt3k is a code owner

Assignees
No one assigned
Labels
uuid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@syhol @iuioiua