fix(expect/assert): missing constructor equality check #4512

marvinhagemeister · 2024-03-22T19:15:21Z

We didn't do any constructor checks when not in strict mode which is wrong.

Fixes #4511

expect/_equal.ts

archive/untar.ts

expect/_equal.ts

iuioiua

One nit. Otherwise, LGTM! Thank you.

marvinhagemeister requested a review from kt3k as a code owner March 22, 2024 19:15

github-actions bot added the expect label Mar 22, 2024

marvinhagemeister commented Mar 22, 2024

View reviewed changes

expect/_equal.ts Show resolved Hide resolved

github-actions bot added the archive label Mar 22, 2024

marvinhagemeister added assert and removed archive labels Mar 22, 2024

github-actions bot added archive and removed assert labels Mar 22, 2024

marvinhagemeister commented Mar 22, 2024

View reviewed changes

archive/untar.ts Outdated Show resolved Hide resolved

marvinhagemeister added 4 commits March 22, 2024 21:27

fix(expect/assert): missing constructor equality check

edfeceb

fix: switch to jest constructor-style checks

e66128d

chore: add one more test case

bb6accc

chore: move test assertion

30a8820

marvinhagemeister force-pushed the constructor-equal branch from 97309e7 to 30a8820 Compare March 22, 2024 20:27

github-actions bot removed the archive label Mar 22, 2024

marvinhagemeister requested a review from iuioiua March 22, 2024 20:29

iuioiua reviewed Mar 22, 2024

View reviewed changes

expect/_equal.ts Outdated Show resolved Hide resolved

iuioiua approved these changes Mar 22, 2024

View reviewed changes

chore: use strict equality check

92e5c77

marvinhagemeister merged commit 4476088 into main Mar 22, 2024
10 checks passed

marvinhagemeister deleted the constructor-equal branch March 22, 2024 21:24

Provide feedback