Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[http] add ParseHTTPVersion #452

Merged
merged 3 commits into from
May 25, 2019
Merged

[http] add ParseHTTPVersion #452

merged 3 commits into from
May 25, 2019

Conversation

zekth
Copy link
Contributor

@zekth zekth commented May 24, 2019

@ry
Copy link
Member

ry commented May 25, 2019

Can you port these tests over?

https://github.com/golang/go/blob/f5c43b9/src/net/http/request_test.go#L535-L565

@zekth
Copy link
Contributor Author

zekth commented May 25, 2019

http/server_test.ts Outdated Show resolved Hide resolved
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit 4381785 into denoland:master May 25, 2019
@zekth zekth deleted the add_parseHttpVersion branch May 25, 2019 16:27
ry pushed a commit to ry/deno that referenced this pull request Oct 9, 2019
inverted-capital pushed a commit to dreamcatcher-tech/napps that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants