Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fs): SubdirectoryMoveError extends Error correctly #4528

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented Mar 27, 2024

The name of a custom error should have the same name as its constructor name. This ensures that for SubdirectoryMoveError and WalkError.

@iuioiua iuioiua requested a review from kt3k as a code owner March 27, 2024 04:04
@github-actions github-actions bot added the fs label Mar 27, 2024
@iuioiua iuioiua changed the title refactor(fs): SubdirectoryMoveError extends Error correctly fix(fs): SubdirectoryMoveError extends Error correctly Mar 27, 2024
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit 9254339 into main Mar 27, 2024
11 checks passed
@iuioiua iuioiua deleted the fs-error branch March 27, 2024 06:09
eryue0220 added a commit to eryue0220/deno_std that referenced this pull request Mar 30, 2024
…220/deno_std into feat/expect-addSnapshotSerializer

* 'feat/expect-addSnapshotSerializer' of github.com:eryue0220/deno_std:
  deprecation(crypto): rename an export to match style guide, deprecating original and two other obsolete imports (denoland#4525)
  chore: add `--allow-dirty` flag to publish dry run (denoland#4535)
  [unstable] BREAKING(semver): remove comparator.semver field (denoland#4533)
  chore(crypto): upgrade dependencies (denoland#4530)
  0.221.0 (denoland#4531)
  docs(fs): polish documentation (denoland#4526)
  fix(fs): `SubdirectoryMoveError` extends `Error` correctly (denoland#4528)
  chore(fs): remove `test.ts` (denoland#4527)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants