Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check file changes during test #476

Merged
merged 3 commits into from
Jun 3, 2019
Merged

Check file changes during test #476

merged 3 commits into from
Jun 3, 2019

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jun 2, 2019

This PR:

  • Uses temp dirs in prettier/main testing.
  • Checks file changes after the test run.

closes #408

ry
ry reviewed Jun 2, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding checkSourceFileChanges - it will be nice to not introduce any inadvertent changes to the source tree.

Just one comment...

test.ts Outdated
async function checkSourceFileChanges(startTime: number): Promise<void> {
await Deno.stdout.write(
new TextEncoder().encode("test checkSourceFileChanges ... ")
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not console.log?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok.

@ry ry merged commit 7daa887 into denoland:master Jun 3, 2019
@kt3k kt3k deleted the feature/use-temp-dir branch June 3, 2019 07:27
ry pushed a commit to ry/deno that referenced this pull request Oct 9, 2019
@kt3k @ry
Check file changes during test (denoland/std#476)
21684c6 
Original: denoland/std@7daa887
inverted-capital pushed a commit to dreamcatcher-tech/napps that referenced this pull request Oct 24, 2024
@iuioiua
refactor: use ULIDs for items (denoland#514)
23be24c 
Please pay attention to the migration script, as it's responsible for
migrating all items and votes. I've also changed all instances of
`monotonicUlid()` to `ulid()` at there appears to be a bug that prevents
`monotonicUlid()` from respecting the `seedTime` parameter.

The migration can be simulated as follows:
1. Switch to **main** branch.
2. Run `deno run db:reset`.
3. Run `deno run db:seed`.
4. Run `deno task start` and navigate to `http://localhost:8000`.
6. Vote some items.
7. Note the voted items and the order of the items feed.
8. Switch to **ulid-items** branch.
9. Run `deno run db:migrate`.
10. Run `deno task start` and navigate to `http://localhost:8000`.
11. Check that the voted items and the order of the items feed are
identical to those previously noted.

Closes denoland#475
Closes denoland#476
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tests make modifications to the source directory
2 participants
@kt3k @ry