Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cli): make check_docs pass #4815

Merged
merged 14 commits into from
May 23, 2024
Merged

docs(cli): make check_docs pass #4815

merged 14 commits into from
May 23, 2024

Conversation

dsherret
Copy link
Member

No description provided.

@dsherret dsherret requested a review from kt3k as a code owner May 21, 2024 19:39
@github-actions github-actions bot added the cli label May 21, 2024
@dsherret dsherret requested a review from littledivy May 21, 2024 19:40
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.97%. Comparing base (50951cc) to head (e47129e).

Current head e47129e differs from pull request most recent head 6e4a0ab

Please upload reports for the commit 6e4a0ab to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4815      +/-   ##
==========================================
- Coverage   91.97%   91.97%   -0.01%     
==========================================
  Files         487      487              
  Lines       41567    41542      -25     
  Branches     5365     5365              
==========================================
- Hits        38233    38208      -25     
  Misses       3276     3276              
  Partials       58       58              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dsherret dsherret changed the title docs(cli): make deno doc --lint cli/mod.ts pass docs(cli): make check_docs pass May 22, 2024
@dsherret dsherret requested a review from kt3k May 22, 2024 18:18
@dsherret
Copy link
Member Author

@kt3k sorry, I made a few additional changes to get it passing check_docs.ts

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM again!

@kt3k kt3k mentioned this pull request May 23, 2024
38 tasks
@dsherret dsherret merged commit c0d7532 into denoland:main May 23, 2024
10 checks passed
@dsherret dsherret deleted the cli_docs branch May 23, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants