Remove console.error from asserts. #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry
pushed a commit
to ry/deno
that referenced
this pull request
Oct 9, 2019
inverted-capital
pushed a commit
to dreamcatcher-tech/napps
that referenced
this pull request
Oct 24, 2024
Changes: 1. Notifications use ULIDs for their IDs. 2. Removes the `notifications` index from KV, as it seems unnecessary. 3. Removed the `createdAt` property from notifications. 4. Removes `newNotificationProps()`, as it now seems unnecessary. Closes denoland#473 Towards denoland#470 CC @lino-levan (this might be a good reference to learn more about ULIDs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the some assertions included logging to
console.error. This doesn't make any sense and generally didn't include any more information than what would be contained in theAssertionError, it also causes content to get logged to console which may not be intended, like when wrapping an assertion and providing a better error message/condition to the user. We should avoid being opinionated about what gets logged to the console instd. If there are critical data (like raw "expected" and "actual" or the type of assertion made) they should be added toAssertionErrorso that consumers have the ability to control how the error is handled.