Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(msgpack): complete documentation of the package #4832

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

lucacasonato
Copy link
Member

No description provided.

@@ -1,5 +1,47 @@
// Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.
// This module is browser compatible.

/**
* MessagePack is an efficient binary serialization format that is language
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice introduction!

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from msgpack_fix_eof to main May 22, 2024 12:17
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.53%. Comparing base (315005c) to head (8c90fb4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4832      +/-   ##
==========================================
- Coverage   91.97%   91.53%   -0.44%     
==========================================
  Files         486      486              
  Lines       41452    41454       +2     
  Branches     5360     5323      -37     
==========================================
- Hits        38124    37946     -178     
- Misses       3270     3448     +178     
- Partials       58       60       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucacasonato lucacasonato merged commit 0e31686 into main May 22, 2024
12 checks passed
@lucacasonato lucacasonato deleted the msgpack_docs branch May 22, 2024 12:20
@kt3k kt3k mentioned this pull request May 23, 2024
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants