Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(crypto): improve docs #4884

Merged
merged 4 commits into from
May 31, 2024
Merged

docs(crypto): improve docs #4884

merged 4 commits into from
May 31, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented May 29, 2024

This PR improves the API doc of crypto package.

part of #4600 #3764

supercedes #4797

@kt3k kt3k requested a review from iuioiua May 29, 2024 10:33
@kt3k kt3k mentioned this pull request May 29, 2024
38 tasks
This was referenced May 29, 2024
crypto/unstable_keystack.ts Show resolved Hide resolved
crypto/unstable_keystack.ts Show resolved Hide resolved
crypto/unstable_keystack.ts Show resolved Hide resolved
crypto/unstable_keystack.ts Show resolved Hide resolved
crypto/unstable_keystack.ts Show resolved Hide resolved
Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.15%. Comparing base (3fbdd93) to head (8dd81f9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4884   +/-   ##
=======================================
  Coverage   92.15%   92.15%           
=======================================
  Files         488      488           
  Lines       38869    38873    +4     
  Branches     5405     5405           
=======================================
+ Hits        35819    35823    +4     
  Misses       2994     2994           
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added assertions to example code snippets and some other tweaks. PTAL.

@kt3k kt3k merged commit f94f8f3 into denoland:main May 31, 2024
12 checks passed
@kt3k kt3k deleted the document-crypto branch May 31, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants