Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(async): avoid memory leak in example #5040

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jun 14, 2024

This reverts #4283

By using Array.fromAsync, the call result of the debounced function is stored in memory i.e. it's leaked unnecessarily. We can avoid it by not using Array.fromAsync.

@github-actions github-actions bot added the async label Jun 14, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.17%. Comparing base (22b4d03) to head (d1a1405).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5040   +/-   ##
=======================================
  Coverage   92.17%   92.17%           
=======================================
  Files         487      487           
  Lines       38796    38796           
  Branches     5433     5433           
=======================================
  Hits        35760    35760           
  Misses       2981     2981           
  Partials       55       55           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k kt3k merged commit df27fe8 into denoland:main Jun 14, 2024
12 checks passed
@kt3k kt3k deleted the docs-avoid-memory-leak branch June 14, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants