Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(testing): remove use of public keyword #5051

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Jun 16, 2024

As we don't use the access modifiers in the Standard Library.

@iuioiua iuioiua requested a review from kt3k as a code owner June 16, 2024 02:27
@iuioiua iuioiua changed the title refactor(testing): remove use of public keyword in refactor(testing): remove use of public keyword Jun 16, 2024
Copy link

codecov bot commented Jun 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.17%. Comparing base (d35f8a3) to head (22e8e8a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5051   +/-   ##
=======================================
  Coverage   92.17%   92.17%           
=======================================
  Files         487      487           
  Lines       38800    38805    +5     
  Branches     5435     5435           
=======================================
+ Hits        35764    35769    +5     
  Misses       2981     2981           
  Partials       55       55           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit 935d665 into main Jun 17, 2024
13 checks passed
@iuioiua iuioiua deleted the testing-remove-public branch June 17, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants