Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): minor cleanups #5052

Merged
merged 2 commits into from
Jun 17, 2024
Merged

refactor(cli): minor cleanups #5052

merged 2 commits into from
Jun 17, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Jun 16, 2024

No description provided.

@iuioiua iuioiua requested a review from kt3k as a code owner June 16, 2024 20:41
@github-actions github-actions bot added the cli label Jun 16, 2024
Copy link

codecov bot commented Jun 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.22%. Comparing base (d35f8a3) to head (4889488).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5052      +/-   ##
==========================================
+ Coverage   92.17%   92.22%   +0.05%     
==========================================
  Files         487      487              
  Lines       38800    38857      +57     
  Branches     5435     5444       +9     
==========================================
+ Hits        35764    35836      +72     
+ Misses       2981     2966      -15     
  Partials       55       55              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cli/unicode_width.ts Outdated Show resolved Hide resolved
@iuioiua iuioiua requested a review from kt3k June 17, 2024 05:46
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@iuioiua iuioiua merged commit 7867a60 into main Jun 17, 2024
12 checks passed
@iuioiua iuioiua deleted the cli-cleanup branch June 17, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants