test(streams): improve Buffer test
#5061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5061 +/- ##
==========================================
- Coverage 92.22% 91.91% -0.31%
==========================================
Files 487 487
Lines 38857 38854 -3
Branches 5444 5417 -27
==========================================
- Hits 35836 35714 -122
- Misses 2966 3083 +117
- Partials 55 57 +2 ☔ View full report in Codecov by Sentry. |
iuioiua
reviewed
Jun 17, 2024
iuioiua
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds test cases for
Bufferclass ofstd/streams, and also removes one dead if-block.This PR improves the line coverage of
Bufferclass from 72.54% to 100%.