Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(streams): improve DelimiterStream test cases #5070

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jun 18, 2024

This PR improves the test suite of DelimiterStream. Now the test cases cover the lines except 'unreachable' lines.

part of #3713

@kt3k kt3k requested a review from crowlKats as a code owner June 18, 2024 05:55
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.40%. Comparing base (8ec230f) to head (de411f2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5070      +/-   ##
==========================================
+ Coverage   92.32%   92.40%   +0.07%     
==========================================
  Files         481      481              
  Lines       38747    38747              
  Branches     5444     5449       +5     
==========================================
+ Hits        35775    35806      +31     
+ Misses       2917     2886      -31     
  Partials       55       55              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua changed the title test(streams): improve DelimiterStream test cases test(streams): improve DelimiterStream test cases Jun 18, 2024
@kt3k kt3k merged commit 6997e8b into denoland:main Jun 18, 2024
13 checks passed
@kt3k kt3k deleted the improve-test-of-delimiter-stream branch June 18, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants