fix: installed module can not get arguments correctly #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @ry |
ry
reviewed
Jun 19, 2019
ry
reviewed
Jun 19, 2019
installer/mod.ts
Outdated
| @@ -153,7 +153,7 @@ async function generateExecutable( | |||
| filePath: string, | |||
| commands: string[] | |||
| ): Promise<void> { | |||
| commands = commands.map((v): string => '"' + v + '"'); | |||
| commands = commands.map((v): string => `"${v.replace(/\"/g, '\\"')}"`); | |||
There was a problem hiding this comment.
Hrm... I don't think this is sufficient to escape the strings properly. (I can't immediately think of a counter example...) What about using JSON.stringify() on the strings?
commands = commands.map(JSON.stringify);There was a problem hiding this comment.
You can leave out the anonymous function I think.
There was a problem hiding this comment.
@ry No, it can't. typescript compiler will throw an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated command is not wrapped in double quotes
This will cause the parameters passed to the script to be incorrect
change: