Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(csv): remove csv from module names #5172

Merged
merged 3 commits into from
Jun 28, 2024
Merged

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Jun 27, 2024

What's changed

The csv-* prefix has been removed from module names in @std/csv. In other words:

  1. @std/csv/csv-parse-stream has moved to @std/csv/parse-stream.
  2. @std/csv/csv-stringify-stream has moved to @std/csv/stringify-stream.

Motivations

These changes were made to shorten these module specifiers while still retaining their context; that they're CSV-oriented streams.

Migration guide

To migrate:

  1. Import from @std/csv/parse-stream instead of @std/csv/csv-parse-stream.

    - import { CsvParseStream } from "@std/csv/csv-parse-stream";
    + import { CsvParseStream } from "@std/csv/parse-stream";
    
    // ...
  2. Import from @std/csv/stringify-stream instead of @std/csv/csv-stringify-stream.

    - import { CsvStringifyStream } from "@std/csv/csv-stringify-stream";
    + import { CsvStringifyStream } from "@std/csv/stringify-stream";
    
    // ...

Towards #5177.

…am` and `csv-parse-stream` to `parse-stream`
@github-actions github-actions bot added the csv label Jun 27, 2024
@iuioiua iuioiua changed the title BREAKING(csv): move modules csv-stringify-stream to stringify-stream and csv-parse-stream to parse-stream BREAKING(csv): remove csv from module names Jun 27, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.34%. Comparing base (4052256) to head (c81d4e0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5172   +/-   ##
=======================================
  Coverage   93.34%   93.34%           
=======================================
  Files         469      469           
  Lines       37917    37917           
  Branches     5386     5386           
=======================================
  Hits        35392    35392           
  Misses       2483     2483           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua marked this pull request as ready for review June 28, 2024 03:59
@iuioiua iuioiua requested a review from kt3k as a code owner June 28, 2024 03:59
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit dc3154c into main Jun 28, 2024
16 checks passed
@iuioiua iuioiua deleted the csv-remove-prefixes branch June 28, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants