Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(json): remove json from module names #5173

Merged
merged 6 commits into from
Jul 2, 2024
Merged

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Jun 27, 2024

What's changed

json has been removed from module names in @std/json. In other words:

  1. @std/json/json-parse-stream has moved to @std/json/parse-stream.
  2. @std/json/json-stringify-stream has moved to @std/json/stringify-stream.

Motivations

These changes were made to shorten these module specifiers while still retaining their context; that they're JSON-oriented streams.

Migration guide

To migrate:

  1. Import from @std/json/parse-stream instead of @std/json/json-parse-stream.

    - import { JsonParseStream } from "@std/json/json-parse-stream";
    + import { JsonParseStream } from "@std/json/parse-stream";
    
    // ...
  2. Import from @std/json/stringify-stream instead of @std/json/json-stringify-stream.

    - import { JsonStringifyStream } from "@std/json/json-stringify-stream";
    + import { JsonStringifyStream } from "@std/json/stringify-stream";
    
    // ...

Closes #5177.

@github-actions github-actions bot added the json label Jun 27, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.95%. Comparing base (b11514e) to head (05bc6da).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5173   +/-   ##
=======================================
  Coverage   94.95%   94.95%           
=======================================
  Files         460      460           
  Lines       38073    38073           
  Branches     5549     5549           
=======================================
  Hits        36154    36154           
  Misses       1878     1878           
  Partials       41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua marked this pull request as ready for review June 28, 2024 03:58
@iuioiua iuioiua requested a review from kt3k as a code owner June 28, 2024 03:58
json/deno.json Show resolved Hide resolved
@iuioiua iuioiua requested a review from kt3k July 1, 2024 22:24
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit c059a3d into main Jul 2, 2024
16 checks passed
@iuioiua iuioiua deleted the json-remove-prefixes branch July 2, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants