refactor(yaml): make readDocument() and readDocuments() generator functions
#5255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5255 +/- ##
==========================================
- Coverage 95.66% 95.66% -0.01%
==========================================
Files 459 459
Lines 38015 38014 -1
Branches 5559 5558 -1
==========================================
- Hits 36368 36367 -1
Misses 1606 1606
Partials 41 41 ☔ View full report in Codecov by Sentry. |
kt3k
reviewed
Jul 2, 2024
iuioiua
approved these changes
Jul 3, 2024
|
Should we also remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readDocuments()and addreadDocuments()generator functionsThis will prevent parsing all documents in
load()before throwing an error.Note: The performance can be enhanced in a future PR by checking whether the state.position is at the end of the state.input instead of parsing a second document. There are some unknown state changes going on somewhere during the parsing. That is why this approach doesn't work atm.