Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(yaml): merge yaml/_loader/ files #5259

Merged
merged 4 commits into from
Jul 2, 2024

Conversation

timreichen
Copy link
Contributor

  • merges _loader/loader.ts and _loader/loader_state.ts into _loader/loader.ts

@timreichen timreichen requested a review from kt3k as a code owner July 2, 2024 20:42
@github-actions github-actions bot added the yaml label Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.66%. Comparing base (6b26d41) to head (2bf0b3f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5259      +/-   ##
==========================================
- Coverage   95.66%   95.66%   -0.01%     
==========================================
  Files         461      460       -1     
  Lines       38028    38021       -7     
  Branches     5560     5560              
==========================================
- Hits        36380    36373       -7     
  Misses       1607     1607              
  Partials       41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua changed the title refactor(yaml): merge loader files refactor(yaml): merge yaml/_loader/ files Jul 2, 2024
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@iuioiua iuioiua merged commit 6f33e7f into denoland:main Jul 2, 2024
16 checks passed
@timreichen timreichen deleted the yaml-merge-loader-files branch August 17, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants