Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(yaml): merge yaml/_dumper/ files #5260

Merged
merged 4 commits into from
Jul 2, 2024

Conversation

timreichen
Copy link
Contributor

@timreichen timreichen commented Jul 2, 2024

  • merges _dumper/dumper.ts and _dumper/dumper_state into _dumper/dumper.ts

@timreichen timreichen requested a review from kt3k as a code owner July 2, 2024 21:14
@github-actions github-actions bot added the yaml label Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 95.38462% with 3 lines in your changes missing coverage. Please review.

Project coverage is 95.30%. Comparing base (6f33e7f) to head (ade2203).

Files Patch % Lines
yaml/_dumper/dumper.ts 95.38% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5260      +/-   ##
==========================================
- Coverage   95.66%   95.30%   -0.37%     
==========================================
  Files         460      459       -1     
  Lines       38020    38015       -5     
  Branches     5559     5528      -31     
==========================================
- Hits        36373    36229     -144     
- Misses       1606     1745     +139     
  Partials       41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timreichen timreichen changed the title refactor(yaml): merge dump files refactor(yaml): merge dumper files Jul 2, 2024
@iuioiua iuioiua changed the title refactor(yaml): merge dumper files refactor(yaml): merge yaml/_dumper/ files Jul 2, 2024
Copy link
Collaborator

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@iuioiua iuioiua enabled auto-merge (squash) July 2, 2024 23:52
@iuioiua iuioiua merged commit 1a11b69 into denoland:main Jul 2, 2024
16 checks passed
@timreichen timreichen deleted the yaml-merge-dumper-files branch August 17, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants