Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(yaml): move loader and dumper files #5270

Merged
merged 1 commit into from
Jul 3, 2024
Merged

refactor(yaml): move loader and dumper files #5270

merged 1 commit into from
Jul 3, 2024

Conversation

timreichen
Copy link
Contributor

  • moves _loader/loader.ts to _loader.ts
  • moves _dumper/dumper.ts to _dumper.ts

@timreichen timreichen requested a review from kt3k as a code owner July 3, 2024 05:57
@github-actions github-actions bot added the yaml label Jul 3, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.70%. Comparing base (735609e) to head (68ab333).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5270   +/-   ##
=======================================
  Coverage   95.70%   95.70%           
=======================================
  Files         459      459           
  Lines       38025    38025           
  Branches     5563     5563           
=======================================
  Hits        36393    36393           
  Misses       1591     1591           
  Partials       41       41

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

iuioiua
iuioiua approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@iuioiua iuioiua merged commit b775a95 into denoland:main Jul 3, 2024
15 checks passed
@timreichen timreichen deleted the yaml-move-loader-and-dumper branch July 3, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuioiua iuioiua iuioiua approved these changes

@kt3k kt3k Awaiting requested review from kt3k kt3k is a code owner

Assignees
No one assigned
Labels
yaml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timreichen @iuioiua