Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(yaml): simplify isWhiteSpaceOrEOL #5271

Merged
merged 4 commits into from
Jul 3, 2024

Conversation

timreichen
Copy link
Contributor

No description provided.

@timreichen timreichen requested a review from kt3k as a code owner July 3, 2024 06:23
@github-actions github-actions bot added the yaml label Jul 3, 2024
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 68.75000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 95.74%. Comparing base (ba704da) to head (1c55f45).

Files Patch % Lines
yaml/_loader.ts 68.75% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5271      +/-   ##
==========================================
- Coverage   95.74%   95.74%   -0.01%     
==========================================
  Files         458      458              
  Lines       37973    37969       -4     
  Branches     5562     5561       -1     
==========================================
- Hits        36356    36352       -4     
  Misses       1576     1576              
  Partials       41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 63233ce into denoland:main Jul 3, 2024
15 checks passed
timreichen added a commit to timreichen/std that referenced this pull request Jul 3, 2024
iuioiua pushed a commit that referenced this pull request Jul 3, 2024
* initial commit

* refactor(yaml): inline error functions as methods (#5273)

* Update _loader.ts

Co-authored-by: Yoshiya Hinosawa <stibium121@gmail.com>

* refactor(yaml): simplify isWhiteSpaceOrEOL (#5271)

* refactor(yaml): replace `Type` class with interface (#5262)

* update

---------

Co-authored-by: Yoshiya Hinosawa <stibium121@gmail.com>
@timreichen timreichen deleted the yaml-simplify-isWhiteSpaceOrEOL branch August 17, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants