Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(yaml): remove style aliases of !!int type #5307

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jul 4, 2024

This PR removes the style aliases of !!int type in stringify API.

No users should be affected by this change.

closes #5272

@github-actions github-actions bot added the yaml label Jul 4, 2024
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.81%. Comparing base (81943c3) to head (fb0a8be).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5307      +/-   ##
==========================================
- Coverage   95.81%   95.81%   -0.01%     
==========================================
  Files         458      458              
  Lines       37883    37861      -22     
  Branches     5567     5566       -1     
==========================================
- Hits        36298    36276      -22     
  Misses       1545     1545              
  Partials       40       40              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup

@kt3k kt3k merged commit 59f5708 into denoland:main Jul 5, 2024
14 checks passed
@kt3k kt3k deleted the breaking-yaml-remove-style-aliases branch July 5, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce StyleVariant aliases in yaml
2 participants