Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(yaml): cleanup inspectNode() #5311

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

timreichen
Copy link
Contributor

  • replaces duplicatesIndexes array with Set of objects
  • reduces nesting and adds early returns

@timreichen timreichen requested a review from kt3k as a code owner July 4, 2024 21:59
@github-actions github-actions bot added the yaml label Jul 4, 2024
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.81%. Comparing base (81943c3) to head (221642e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5311      +/-   ##
==========================================
- Coverage   95.81%   95.81%   -0.01%     
==========================================
  Files         458      458              
  Lines       37883    37870      -13     
  Branches     5567     5566       -1     
==========================================
- Hits        36298    36285      -13     
  Misses       1545     1545              
  Partials       40       40              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup. Thank you.

@iuioiua iuioiua merged commit fe2dd55 into denoland:main Jul 4, 2024
13 checks passed
@timreichen timreichen deleted the yaml-cleanup-inspectNode branch July 4, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants