Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(yaml): move getObjectTypeString() #5332

Merged

Conversation

timreichen
Copy link
Contributor

  • moves getObjectTypeString() to _utils.ts as it can be shared.

@timreichen timreichen requested a review from kt3k as a code owner July 5, 2024 07:12
@github-actions github-actions bot added the yaml label Jul 5, 2024
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.80%. Comparing base (25aa6fa) to head (cf6829a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5332   +/-   ##
=======================================
  Coverage   95.80%   95.80%           
=======================================
  Files         458      458           
  Lines       37863    37871    +8     
  Branches     5562     5562           
=======================================
+ Hits        36275    36283    +8     
  Misses       1548     1548           
  Partials       40       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k
Copy link
Member

kt3k commented Jul 5, 2024

Can you also replace the usages in yaml/_type/omap.ts and yaml/_type/pairs.ts?

Copy link
Collaborator

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, Tim.

@iuioiua iuioiua merged commit 5cccc4b into denoland:main Jul 6, 2024
13 checks passed
@timreichen timreichen deleted the yaml-move-getObjectTypeString-to-utils branch July 6, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants