Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(yaml): add test cases of stringify #5350

Merged

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jul 8, 2024

This PR adds test cases yaml.stringify, which exercise 'folded style' of string value, and flow sequence styles of lists and mappings.

This change improves the line coverage of yaml/_dumper.ts from 70.56% to 85.41%

@github-actions github-actions bot added the yaml label Jul 8, 2024
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.24%. Comparing base (a0b4103) to head (1318e96).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5350      +/-   ##
==========================================
+ Coverage   95.94%   96.24%   +0.29%     
==========================================
  Files         458      458              
  Lines       37849    37849              
  Branches     5582     5608      +26     
==========================================
+ Hits        36314    36427     +113     
+ Misses       1494     1381     -113     
  Partials       41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k kt3k merged commit 1ff4af8 into denoland:main Jul 8, 2024
14 checks passed
@kt3k kt3k deleted the test-yaml-stringify-folded-scalar-and-flow-style branch July 8, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants