Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): escape CR in snapshot files #5352

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jul 8, 2024

closes #4226

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.94%. Comparing base (a0b4103) to head (0bf05fb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5352   +/-   ##
=======================================
  Coverage   95.94%   95.94%           
=======================================
  Files         458      458           
  Lines       37849    37849           
  Branches     5582     5582           
=======================================
  Hits        36314    36314           
  Misses       1494     1494           
  Partials       41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

testing/snapshot.ts Outdated Show resolved Hide resolved
@kt3k kt3k merged commit 0d668fa into denoland:main Jul 8, 2024
13 checks passed
@kt3k kt3k deleted the fix-testing-escape-carriage-return branch July 8, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

assertSnapshot fails to match carriage return
2 participants