Ignore error of writing responses to aborted requests #546
Conversation
|
This swallows only aborted connections? Or it may swallow also unexpected errors? Just wondering. |
|
@zekth |
|
I skipped the test case on windows because it doesn't implement |
http/util.ts
Outdated
| @@ -0,0 +1,9 @@ | |||
| // Sleeps the given milliseconds and resolves. | |||
| export function sleep(ms: number): Promise<void> { | |||
There was a problem hiding this comment.
Nice addition. But we may also add this to _std? i often use it personnaly.
There was a problem hiding this comment.
I agree. This util is very useful. I moved the function to util/async.ts. (I also changed the name to delay because it sounds more general and node.js has delay module with almost the same purpose.)
http/server_test.ts
Outdated
| assert(serverIsRunning); | ||
| } finally { | ||
| // Stops the sever. | ||
| p.kill(2); // SIGINT |
| @@ -0,0 +1,9 @@ | |||
| import { serve } from "../server.ts"; | |||
There was a problem hiding this comment.
Can you add a comment describing the purpose of this
// This is an example of a server that responds with an empty body
This PR fixes the case described in #442. The test case reproduces the case given by @MarkTiedemann in the comment ( #442 (comment) ).
This change simply ignore the error when the writing failed.
I believe the corresponding part of go's std library is here.
This doesn't handle the error returned by
fmt.Fprintf. So this patch follows the above.closes #442