Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(yaml): move exports to import file #5651

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

timreichen
Copy link
Contributor

Changes
This PR moves exported functions to the import file, since the code only imported in one file.

@timreichen timreichen requested a review from kt3k as a code owner August 7, 2024 12:54
@github-actions github-actions bot added the yaml label Aug 7, 2024
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 95.12195% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.21%. Comparing base (ce02d49) to head (d2d2ba1).

Files Patch % Lines
yaml/stringify.ts 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5651      +/-   ##
==========================================
- Coverage   96.21%   96.21%   -0.01%     
==========================================
  Files         470      470              
  Lines       38204    38196       -8     
  Branches     5549     5550       +1     
==========================================
- Hits        36759    36751       -8     
- Misses       1403     1404       +1     
+ Partials       42       41       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua
Copy link
Contributor

iuioiua commented Aug 8, 2024

PTAL @kt3k

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit 8e32dac into denoland:main Aug 8, 2024
13 checks passed
@timreichen timreichen deleted the yaml-relocate branch August 8, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants