Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(io): document std/io #5656

Merged
merged 10 commits into from
Aug 8, 2024
Merged

docs(io): document std/io #5656

merged 10 commits into from
Aug 8, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Aug 8, 2024

part of #3764

@github-actions github-actions bot added the io label Aug 8, 2024
@kt3k
Copy link
Member Author

kt3k commented Aug 8, 2024

@iuioiua PTAL

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 5 lines in your changes missing coverage. Please review.

Project coverage is 96.26%. Comparing base (1047864) to head (bc17861).

Files Patch % Lines
io/buf_writer.ts 90.90% 3 Missing ⚠️
io/buf_reader.ts 92.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5656   +/-   ##
=======================================
  Coverage   96.25%   96.26%           
=======================================
  Files         470      470           
  Lines       38188    38251   +63     
  Branches     5545     5545           
=======================================
+ Hits        36759    36821   +62     
- Misses       1387     1388    +1     
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua mentioned this pull request Aug 8, 2024
38 tasks
Copy link
Collaborator

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Once we trim the package of its deprecated APIs, we should revisit some symbols. Namely, options which don't have their own interfaces don't display their properties' JSDocs correctly.

@kt3k kt3k merged commit d93b33a into denoland:main Aug 8, 2024
13 checks passed
@kt3k kt3k deleted the docs-io branch August 8, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants