Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(front-matter): remove Extractor type #5659

Merged
merged 1 commit into from
Aug 8, 2024
Merged

refactor(front-matter): remove Extractor type #5659

merged 1 commit into from
Aug 8, 2024

Conversation

timreichen
Copy link
Contributor

Changes
This PR removes the Extractor type and moves Format type to _formats.ts.

Reasoning
Extractor is not used anywhere.

@timreichen timreichen requested a review from kt3k as a code owner August 8, 2024 20:45
iuioiua
iuioiua approved these changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@iuioiua iuioiua merged commit 860f578 into denoland:main Aug 8, 2024
11 checks passed
@timreichen timreichen deleted the front_matter-remove-Extractor branch August 8, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuioiua iuioiua iuioiua approved these changes

@kt3k kt3k Awaiting requested review from kt3k kt3k is a code owner

Assignees
No one assigned
Labels
front-matter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timreichen @iuioiua