Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cache/unstable): fix flaky memoize() test with FakeTime #5664

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

lionel-rowe
Copy link
Contributor

Fixes #5663

@lionel-rowe lionel-rowe requested a review from kt3k as a code owner August 9, 2024 08:46
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.26%. Comparing base (860f578) to head (6d90ef3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5664   +/-   ##
=======================================
  Coverage   96.26%   96.26%           
=======================================
  Files         473      473           
  Lines       38390    38390           
  Branches     5571     5571           
=======================================
+ Hits        36955    36956    +1     
+ Misses       1393     1392    -1     
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua changed the title fix(cache/unstable): fix flaky async test with FakeTime fix(cache/unstable): fix flaky memoize() test with FakeTime Aug 9, 2024
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you.

@iuioiua iuioiua merged commit e1dfe0c into denoland:main Aug 9, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(cache): flaky memoize() works with async functions test
2 participants