Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add types to prettier #591

Merged
merged 2 commits into from
Sep 10, 2019
Merged

feat: Add types to prettier #591

merged 2 commits into from
Sep 10, 2019

Conversation

bartlomieju
Copy link
Member

This PR adds types to prettier.

WARNING: types are for 1.18 version, while prettier/ uses 1.17.1 version. I couldn't find types 1.18, so it's a good idea to update prettier anyway.

This was suggested by @MarkTiedemann in denoland/deno#2490 and providing types significantly shortens time to compile prettier`

Before:
$ time deno --reload --no-prompt ../deno_std/prettier/main.ts
real	0m36.094s
user	0m43.474s
sys	0m1.148s

After:
$ time deno_dev --reload --no-prompt ../deno_std/prettier/main.ts
real	0m6.710s
user	0m10.205s
sys	0m0.232s

(Note that after is debug build, while before is v0.17.0 release)

To get this to work we need to land denoland/deno#2910 first

@bartlomieju
Copy link
Member Author

@axetroy can you upgrade prettier to 1.18?

@ry
Copy link
Member

ry commented Sep 10, 2019 •
edited
Loading

Nice! Good suggestion @MarkTiedemann !

@bartlomieju
Copy link
Member Author

It works fine for me with denoland/deno#2910 and it's just ignored without it.

I can update prettier tomorrow to match version of types.

ry
ry approved these changes Sep 10, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit 73fe36f into denoland:master Sep 10, 2019
@bartlomieju bartlomieju deleted the feat-prettier_types branch September 10, 2019 21:44
@axetroy axetroy mentioned this pull request Sep 11, 2019
Merged
ry pushed a commit to ry/deno that referenced this pull request Oct 9, 2019
@bartlomieju @ry
feat: Add types to prettier (denoland/std#591)
4078bc7 
Original: denoland/std@73fe36f
inverted-capital pushed a commit to dreamcatcher-tech/napps that referenced this pull request Oct 24, 2024
@Jabolol @iuioiua
feat: harden headers security (denoland#592)
d3bc49b 
Work in progress. See denoland#591 for the relevant discussion.

---------

Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartlomieju @ry