Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(assert): remove unnecessary getValFromKeyedCollection() #5921

Merged

Conversation

lionel-rowe
Copy link
Contributor

Realized it's no longer necessary due to using the symmetricDifference extra-fast-path for sets.

Copy link

codecov bot commented Sep 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.24%. Comparing base (2fe19de) to head (b71ddac).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5921      +/-   ##
==========================================
- Coverage   96.25%   96.24%   -0.01%     
==========================================
  Files         491      491              
  Lines       39464    39459       -5     
  Branches     5825     5824       -1     
==========================================
- Hits        37986    37979       -7     
- Misses       1434     1436       +2     
  Partials       44       44              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

assert/equal.ts Outdated Show resolved Hide resolved
@iuioiua iuioiua changed the title refactor(assert): remove unnecessary getValFromKeyedCollection function refactor(assert): remove unnecessary getValFromKeyedCollection() Sep 9, 2024
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you.

@iuioiua iuioiua merged commit 23b4d2a into denoland:main Sep 9, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants