Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(assert,expect): import internal APIs from more specific paths #5923

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Sep 9, 2024

This PR changes import specifiers for @std/internal more specific to avoid unnecessary dependencies included after #5901 landed.

#5901 introduces a new @std/internal API which are not necessary for these APIs.

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.24%. Comparing base (23b4d2a) to head (f2b0263).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5923      +/-   ##
==========================================
- Coverage   96.25%   96.24%   -0.01%     
==========================================
  Files         491      489       -2     
  Lines       39459    39457       -2     
  Branches     5824     5824              
==========================================
- Hits        37982    37977       -5     
- Misses       1433     1436       +3     
  Partials       44       44              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@kt3k kt3k merged commit b3e1ebb into denoland:main Sep 9, 2024
16 checks passed
@kt3k kt3k deleted the use-granular-import-from-internal branch September 9, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants