Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(io): add Seeker[Sync] interfaces #5930

Merged
merged 1 commit into from
Sep 10, 2024
Merged

feat(io): add Seeker[Sync] interfaces #5930

merged 1 commit into from
Sep 10, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Sep 10, 2024

After an offline chat with Bartek, we'll be removing Deno.Seeker[Sync], which should've been a part of denoland/deno#9795.

@iuioiua iuioiua requested a review from kt3k as a code owner September 10, 2024 05:29
@github-actions github-actions bot added the io label Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.25%. Comparing base (b3e1ebb) to head (483d852).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5930   +/-   ##
=======================================
  Coverage   96.25%   96.25%           
=======================================
  Files         489      489           
  Lines       39457    39457           
  Branches     5824     5824           
=======================================
  Hits        37980    37980           
  Misses       1433     1433           
  Partials       44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit 9c36e5e into main Sep 10, 2024
16 checks passed
@iuioiua iuioiua deleted the seeker branch September 10, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants