-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING(path/unstable): move unstable overload of dirname
to unstable-dirname
#5954
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5954 +/- ##
=======================================
Coverage 96.31% 96.32%
=======================================
Files 483 484 +1
Lines 39402 39403 +1
Branches 5839 5837 -2
=======================================
+ Hits 37952 37956 +4
+ Misses 1408 1405 -3
Partials 42 42 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, we should suggest to use the unstable APIs in the stable API's documentation.
path/dirname.ts
Outdated
* } | ||
* ``` | ||
* Note: If you are working with file URLs, | ||
* use `dirname` from `@std/path/unstable-dirname`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This suggests that the unstable API will one day become the stable API. Ditto for the other functions.
* use `dirname` from `@std/path/unstable-dirname`. | |
* use the new version of `dirname` from `@std/path/unstable-dirname`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. We really should document our new convention for unstable modules somewhere.
part of #5920
This PR moves the 2nd overload of
dirname
functions to./unstable-dirname
.Unstable versions of
dirname
functions are only available fromunstable-dirname
,posix/unstable-dirname
, orwindows/unstable-dirname
.If this looks fine, I'll work on the rest of items in
@std/path