Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(net): add back get-network-address module to fix http@1.0.5/file-server #5970

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Sep 12, 2024

http@1.0.5/file-server is now broken because it depends on net@^1.0.2/get-network-address which now resolves to net@1.0.3/get-network-address, but that path doesn't exist in net@1.0.3 (because of this change #5949 ). This PR fixes it.

@github-actions github-actions bot added the net label Sep 12, 2024
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.31%. Comparing base (c5d7930) to head (114f1a2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5970      +/-   ##
==========================================
+ Coverage   96.30%   96.31%   +0.01%     
==========================================
  Files         493      493              
  Lines       39507    39507              
  Branches     5836     5836              
==========================================
+ Hits        38047    38053       +6     
+ Misses       1418     1412       -6     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It would be nice to have a lint in deno std to detect stable code depending on unstable code and ban that.

@kt3k
Copy link
Member Author

kt3k commented Sep 12, 2024

It would be nice to have a lint in deno std to detect stable code depending on unstable code and ban that.

Sounds a good idea 👍

@kt3k kt3k merged commit ad67a17 into denoland:main Sep 12, 2024
17 checks passed
@kt3k kt3k deleted the fix-net-get-network-address branch September 13, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants