Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(tar): fix example in creating directories #6113

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

BlackAsLight
Copy link
Contributor

This pull request fixes a highly probable bug in the JSDocs example where if the directory already exists, it throws an error, or if the directory's directory doesn't exist, it throws an error.

@BlackAsLight BlackAsLight requested a review from kt3k as a code owner October 13, 2024 07:05
@github-actions github-actions bot added the tar label Oct 13, 2024
Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.57%. Comparing base (d85d0d8) to head (d07a08b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6113   +/-   ##
=======================================
  Coverage   96.57%   96.57%           
=======================================
  Files         534      534           
  Lines       40550    40550           
  Branches     6085     6086    +1     
=======================================
+ Hits        39160    39162    +2     
+ Misses       1346     1344    -2     
  Partials       44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kt3k kt3k merged commit 825f311 into denoland:main Oct 16, 2024
19 checks passed
@BlackAsLight BlackAsLight deleted the tar_docs branch October 16, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants