Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [ws] wss support with dialTLS #615

Merged
merged 2 commits into from
Sep 28, 2019
Merged

feat: [ws] wss support with dialTLS #615

merged 2 commits into from
Sep 28, 2019

Conversation

keroxp
Copy link
Contributor

@keroxp keroxp commented Sep 28, 2019 •
edited
Loading

  • feat: wss support with dialTLS
  • fixed: Default port check by url.protocol was not working

ry
ry approved these changes Sep 28, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

ws/mod.ts
conn = await Deno.dial({ hostname, port });
} else if (url.protocol === "https:" || url.protocol === "wss:") {
const port = parseInt(url.port || "443");
conn = await Deno.dialTLS({ hostname, port });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we should make it so dialTLS also accepts port as a string...

@ry ry merged commit cac2d5e into denoland:master Sep 28, 2019
ry pushed a commit to ry/deno that referenced this pull request Oct 9, 2019
@keroxp @ry
feat: wss support with dialTLS (denoland/std#615)
3cba0a4 
Original: denoland/std@cac2d5e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keroxp @ry