-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(testing): add missing methods to test
alias of it
#6222
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6222 +/- ##
==========================================
- Coverage 96.53% 96.52% -0.02%
==========================================
Files 534 534
Lines 40952 40967 +15
Branches 6133 6133
==========================================
+ Hits 39535 39542 +7
- Misses 1375 1382 +7
- Partials 42 43 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good to me. Thanks for working on this. Left a few questions.
testing/bdd.ts
Outdated
const options = itDefinition(...args); | ||
return it({ | ||
...options, | ||
only: true, | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use it.only
?
const options = itDefinition(...args); | |
return it({ | |
...options, | |
only: true, | |
}); | |
it.only(...args); |
testing/bdd.ts
Outdated
const options = itDefinition(...args); | ||
return it({ | ||
...options, | ||
ignore: true, | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use it.ignore
?
const options = itDefinition(...args); | |
return it({ | |
...options, | |
ignore: true, | |
}); | |
it.ignore(...args); |
You’re right. I made the requested changes, and I also added some tests. However, I’m not completely confident about these tests because I copied an existing |
I don't think we need new test cases for these as they only have single line implementations, and no new logics are introduced. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
test
is documented as an alias forit
, but it does not currently implement methods likeonly
,ignore
, andskip
. This PR fixes the issue by ensuringtest
correctly mirrors the behavior and methods ofit
.Fixes #6220