Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move fs/path to the top-level #624

Closed
wants to merge 5 commits into from
Closed

Conversation

nayeemrmn
Copy link
Contributor

Closes #623.

  • Move fs/path to the top-level.
  • Remove fs/path.ts.
  • Extract fs/expand_glob.ts from path/glob.ts.
  • Move EOL and isWindows from path/constants.ts to fs/constants.ts, rename EOL to EOL_ (name conflict).

@ry
Copy link
Member

ry commented Oct 7, 2019

Aren't paths only involved with fs stuff? It seems reasonable to me that it be a submodule of fs.

@nayeemrmn
Copy link
Contributor Author

Aren't paths only involved with fs stuff? It seems reasonable to me that it be a submodule of fs.

In terms of the functionality provided by deno_std? I'd consider them parallels above Deno core.

It's mostly the export structure. As a submodule of fs, it should be exposed through fs/mod.ts like any other. But at that point the names become insufficient: import { normalize } from "./fs/mod.ts". There's just too much in fs considering a meaningful chunk of it is strictly path stuff.

@ry
Copy link
Member

ry commented Oct 10, 2019

@nayeemrmn I apologize but would you mind re-submitting this as a PR to denoland/deno ?

I've just merged deno_std into the main repo - this code base is now historical. See #630

@ry ry closed this Oct 10, 2019
@nayeemrmn nayeemrmn deleted the path-move branch February 2, 2021 16:16
inverted-capital pushed a commit to dreamcatcher-tech/napps that referenced this pull request Oct 24, 2024
This console message directs the dev to where they can learn to set up
Stripe.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fs export structure
2 participants