Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(testing): clarify beforeAll in describe vs. outside #6294

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

dandv
Copy link
Contributor

@dandv dandv commented Dec 22, 2024

No description provided.

@dandv dandv requested a review from kt3k as a code owner December 22, 2024 20:53
Copy link

codecov bot commented Dec 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.34%. Comparing base (d625a03) to head (fbb5401).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6294   +/-   ##
=======================================
  Coverage   96.34%   96.34%           
=======================================
  Files         547      547           
  Lines       41661    41661           
  Branches     6313     6313           
=======================================
  Hits        40137    40137           
  Misses       1482     1482           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k kt3k changed the title docs(bdd): clarify beforeAll in describe vs. outside docs(testing): clarify beforeAll in describe vs. outside Dec 23, 2024
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kt3k kt3k merged commit ed52423 into denoland:main Dec 23, 2024
18 of 19 checks passed
@dandv dandv deleted the patch-4 branch December 23, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants