Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(async/unstable): add retry() tests #6423

Merged
merged 4 commits into from
Feb 19, 2025

Conversation

timreichen
Copy link
Contributor

This PR adds tests for invalid option values where the function is expected to throw.

@timreichen timreichen requested a review from kt3k as a code owner February 18, 2025 22:03
@github-actions github-actions bot added the async label Feb 18, 2025
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.04%. Comparing base (431ed58) to head (3306fc3).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6423   +/-   ##
=======================================
  Coverage   96.03%   96.04%           
=======================================
  Files         561      562    +1     
  Lines       42395    42421   +26     
  Branches     6384     6385    +1     
=======================================
+ Hits        40714    40742   +28     
+ Misses       1641     1640    -1     
+ Partials       40       39    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit b6e6bf0 into denoland:main Feb 19, 2025
18 checks passed
@timreichen timreichen deleted the async-retry-add-option-tests branch February 19, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants