Include deno.enablePatterns on config schema #126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new config option, `deno.enablePatterns`, was added in denoland#92. The [config schema](https://code.visualstudio.com/api/references/contribution-points#contributes.configuration) wasn't added, probably because there's no UI editor for "array" type. However, it's still worth defining. 1. To avoid this misleading feedback: 2. To get an indication in the Settings UI that the key exists and can be edited in the JSON: > Other types, such as object and array, aren't exposed directly in the settings UI, and can only be modified by editing the JSON directly. Instead of controls for editing them, users will see a link to Edit in settings.json as shown in the screenshot above.
|
Please merge with master |
|
@David-Else thanks for pointing out that #125 wiped out the That feature is essential in codebases that mix Deno and non-Deno code. @bartlomieju would you accept it again? |
|
@turadg sure! Sorry I didn't carry it over |
|
Closing this since it doesn't make sense without #153 as in included in that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new config option,
deno.enablePatterns, was added in #92. The config schema wasn't added, probably because there's no UI editor for "array" type. However, it's still worth defining.