Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix packaging of extension #507

Merged
merged 1 commit into from
Aug 26, 2021
Merged

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Aug 26, 2021

I made a mistake on the bundling, when the extension was installed it couldn't find language service plugin. I have change the bundling so it does find it now as well as updated to the latest version of vsce which uses the new format for .vscodeignore.

@kitsonk kitsonk requested a review from dsherret August 26, 2021 04:57
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kitsonk kitsonk merged commit 77b432c into denoland:main Aug 26, 2021
@kitsonk kitsonk deleted the fix_bundle_plugin branch August 26, 2021 21:30
kitsonk added a commit to kitsonk/vscode_deno that referenced this pull request Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants