Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: debug config provider #513

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Aug 30, 2021

This deals with two issues that were causing challenges when configuring debug:

  • There was a static config in the package.json which then causes the debug provider to not actually work.
  • The debug provider did not take into account the context, meaning that if you were using an import map, a cache path, or a config file, none of those would be configured to automatically occur when starting debug or generating a launch.json.

In addition, the naming of the launch tasks have been adjusted to be better aligned with Chrome and Node.js debug configurations provided by vscode.

@kitsonk kitsonk requested a review from dsherret August 30, 2021 10:36
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too! Nice change.

@kitsonk kitsonk merged commit 9e2a155 into denoland:main Aug 30, 2021
@kitsonk kitsonk deleted the fix_debug_provider branch August 30, 2021 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants